Re: [PATCH v4 6/6] arm64: Enable perf events based hard lockup detector

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > to re-initialize lockup detection once PMU has been initialized.
> > 
> > [1]: http://lore.kernel.org/linux-arm-kernel/1610712101-14929-1-git-send-email-sumit.garg@xxxxxxxxxx
> > 
> > --- a/arch/arm64/kernel/perf_event.c
> > +++ b/arch/arm64/kernel/perf_event.c
> > @@ -1390,10 +1391,15 @@ static struct platform_driver armv8_pmu_driver = {
> >  
> >  static int __init armv8_pmu_driver_init(void)
> >  {
> > +	int ret;
> > +
> >  	if (acpi_disabled)
> > -		return platform_driver_register(&armv8_pmu_driver);
> > +		ret = platform_driver_register(&armv8_pmu_driver);
> >  	else
> > -		return arm_pmu_acpi_probe(armv8_pmuv3_pmu_init);
> > +		ret = arm_pmu_acpi_probe(armv8_pmuv3_pmu_init);
> > +
> > +	retry_lockup_detector_init();
> 
> Does it makes sense to call retry_lockup_detector_init() when
> the above returned an error? Should it be?
> 
> 	if (!ret)
> 		retry_lockup_detector_init();

Oh I think you're right, I'll add a checking here.
> 
> > +	return ret;
> >  }
> >  device_initcall(armv8_pmu_driver_init)
> 
> 
> I am not qualified to ack the arm-specific code. But otherwise
> the change looks reasonable.

Thanks for your help, I'l rebase on 5.19 -rc1 and seek reviewing for
ARM relative part.


thanks
BRs,
Lecopzer





[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux