Again, I prefer Greg to take these through his tty tree. Changes done by this serie: 1) Create termbits-common.h for the most obvious termbits.h intersection. 2) Reformat some lines that remain in termbits.h files. 3) Don't include posix_types.h unnecessarily. Please do check I got the uapi include things done correctly! That is, that including using asm-generic/termbits-common.h path is the preferred approach for a header file that is not supposed to be overridden by the arch specific header files and that mandatory-y is not required for termbits-common.h. Unfortunately I couldn't move also tcflag_t into termbits-common.h due to the way it is being defined for sparc. However, by the looks of how the type for tcflag_t is being chosen there, having just unsigned int might work also for sparc? Ilpo Järvinen (3): termbits.h: create termbits-common.h for identical bits termbits.h: Align lines & format termbits.h: Remove posix_types.h include arch/alpha/include/uapi/asm/termbits.h | 182 ++++++----------- arch/mips/include/uapi/asm/termbits.h | 209 ++++++++----------- arch/parisc/include/uapi/asm/termbits.h | 131 ++++-------- arch/powerpc/include/uapi/asm/termbits.h | 152 +++++--------- arch/sparc/include/uapi/asm/termbits.h | 223 ++++++++------------- include/uapi/asm-generic/termbits-common.h | 65 ++++++ include/uapi/asm-generic/termbits.h | 129 ++++-------- 7 files changed, 418 insertions(+), 673 deletions(-) create mode 100644 include/uapi/asm-generic/termbits-common.h -- 2.30.2