On Sat 2022-02-12 18:43:46, Lecopzer Chen wrote:
>
> Nobody cares about the return value of watchdog_nmi_enable(),
> changing its prototype to void.
>
> --- a/arch/sparc/kernel/nmi.c
> +++ b/arch/sparc/kernel/nmi.c
> @@ -282,11 +282,11 @@ __setup("nmi_watchdog=", setup_nmi_watchdog);
> * sparc specific NMI watchdog enable function.
> * Enables watchdog if it is not enabled already.
> */
> -int watchdog_nmi_enable(unsigned int cpu)
> +void watchdog_nmi_enable(unsigned int cpu)
> {
> if (atomic_read(&nmi_active) == -1) {
> pr_warn("NMI watchdog cannot be enabled or disabled\n");
> - return -1;
> + return;
> }
>
> /*
> @@ -295,11 +295,11 @@ int watchdog_nmi_enable(unsigned int cpu)
> * process first.
> */
> if (!nmi_init_done)
> - return 0;
> + return;
>
> smp_call_function_single(cpu, start_nmi_watchdog, NULL, 1);
>
> - return 0;
> + return;
Return at the end of the function is superfluous.
> }
> /*
> * sparc specific NMI watchdog disable function.
Otherwise, it looks good.
Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
Best Regards,
Petr
