On Thu, Jan 20, 2022 at 5:35 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Thu, Jan 20, 2022 at 8:38 AM <guoren@xxxxxxxxxx> wrote: > > > @@ -0,0 +1,136 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +#ifndef __ASM_COMPAT_H > > +#define __ASM_COMPAT_H > > + > > +#define compat_mode_t compat_mode_t > > +typedef u16 compat_mode_t; > > I think this one is wrong, as rv32 should get the native definition from > > include/uapi/asm-generic/posix_types.h:typedef unsigned int __kernel_mode_t; > > I think it works if you just remove those two lines. The rest looks good to me. Yes, you are right. compat_mode_t should be unsigned int. > > Arnd -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/