On Tue, Nov 30 2021 at 23:10, Thomas Gleixner wrote: > On Tue, Nov 30 2021 at 22:48, Cédric Le Goater wrote: >> On 11/29/21 22:38, Thomas Gleixner wrote: >>> On Mon, Nov 29 2021 at 08:33, Cédric Le Goater wrote: >>> thanks for having a look. I fixed up this and other fallout and pushed out an >>> updated series (all 4 parts) to: >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel msi >> >> pSeries fails to allocate MSIs starting with this patch : >> >> [PATCH 049/101] powerpc/pseries/msi: Let core code check for contiguous ... >> >> I will dig in later on. > > Let me stare at the core function.. It's not the core function. It's the patch above and I'm a moron. --- a/arch/powerpc/platforms/pseries/msi.c +++ b/arch/powerpc/platforms/pseries/msi.c @@ -359,9 +359,6 @@ static int rtas_prepare_msi_irqs(struct if (quota && quota < nvec) return quota; - if (type == PCI_CAP_ID_MSIX) - return -EINVAL; - /* * Firmware currently refuse any non power of two allocation * so we round up if the quota will allow it.