Re: [PATCH v5 12/16] PCI: Add pci_iomap_host_shared(), pci_iomap_host_shared_range()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v5 12/16] PCI: Add pci_iomap_host_shared(), pci_iomap_host_shared_range()
From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
Date: Mon, 11 Oct 2021 10:23:00 -0700
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, James E J Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, "Michael S . Tsirkin" <mst@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Andrea Arcangeli <aarcange@xxxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, Peter H Anvin <hpa@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Kirill Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>, Sean Christopherson <seanjc@xxxxxxxxxx>, Kuppuswamy Sathyanarayanan <knsathya@xxxxxxxxxx>, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
In-reply-to: <YWPunfa+WK86Cgnv@infradead.org>
References: <20211009003711.1390019-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20211009003711.1390019-13-sathyanarayanan.kuppuswamy@linux.intel.com> <YWPunfa+WK86Cgnv@infradead.org>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

On 10/11/2021 12:58 AM, Christoph Hellwig wrote:

Just as last time:  This does not make any sense.  ioremap is shared
by definition.

It's not necessarily shared with the host for confidential computing:for example BIOS mappings definitely should not be shared, but they'reusing ioremap today.

But if you have a better term please propose something. I tried toclarify it with "shared_host", but I don't know a better term.


-Andi

Follow-Ups:
- Re: [PATCH v5 12/16] PCI: Add pci_iomap_host_shared(), pci_iomap_host_shared_range()
  - From: Michael S. Tsirkin

References:
- [PATCH v5 00/16] Add TDX Guest Support (shared-mm support)
  - From: Kuppuswamy Sathyanarayanan
- [PATCH v5 12/16] PCI: Add pci_iomap_host_shared(), pci_iomap_host_shared_range()
  - From: Kuppuswamy Sathyanarayanan
- Re: [PATCH v5 12/16] PCI: Add pci_iomap_host_shared(), pci_iomap_host_shared_range()
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH v5 16/16] x86/tdx: Add cmdline option to force use of ioremap_host_shared
Next by Date: Re: [PATCH v5 12/16] PCI: Add pci_iomap_host_shared(), pci_iomap_host_shared_range()
Previous by thread: Re: [PATCH v5 12/16] PCI: Add pci_iomap_host_shared(), pci_iomap_host_shared_range()
Next by thread: Re: [PATCH v5 12/16] PCI: Add pci_iomap_host_shared(), pci_iomap_host_shared_range()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [DCCP] [Linux ARM Development] [Linux] [Photo] [Yosemite Help] [Linux ARM Kernel] [Linux SCSI] [Linux x86_64] [Linux Hams]