Re: [PATCH 1/2] sparc32: remove dma_make_coherent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 20, 2021 at 06:07:16PM +0200, Sam Ravnborg wrote:
> On Mon, Sep 20, 2021 at 01:31:07PM +0200, Christoph Hellwig wrote:
> > LEON only needs snooping when DMA accesses are not seen on the processor
> > bus.  Given that coherent allocations are mapped uncached this can't
> > happen for those, so open code the d-cache flushing logic in the only
> > remaing place that needs it, arch_sync_dma_for_cpu.

> I do not see this change explicitly explained in the changelog.
> Is this not one of the "only remaining place that needs it"?

Yes.  Two callers, one needs it, one doesn't.

> Would be nice to see it explicitly mentioned.

Ok.  I'll respin with a more detailed commit log.



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux