From: Jing Yangyang <jing.yangyang@xxxxxxxxxx> Use BUG_ON instead of a if condition followed by BUG. Generated by: scripts/coccinelle/misc/bugon.cocci Reported-by: Zeal Robot <zealci@xxxxxxxxxx> Signed-off-by: Jing Yangyang <jing.yangyang@xxxxxxxxxx> --- arch/sparc/mm/fault_64.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/sparc/mm/fault_64.c b/arch/sparc/mm/fault_64.c index 9a9652a..672f11b 100644 --- a/arch/sparc/mm/fault_64.c +++ b/arch/sparc/mm/fault_64.c @@ -280,9 +280,8 @@ asmlinkage void __kprobes do_sparc64_fault(struct pt_regs *regs) si_code = SEGV_MAPERR; address = current_thread_info()->fault_address; - if ((fault_code & FAULT_CODE_ITLB) && - (fault_code & FAULT_CODE_DTLB)) - BUG(); + BUG_ON((fault_code & FAULT_CODE_ITLB) && + (fault_code & FAULT_CODE_DTLB)); if (test_thread_flag(TIF_32BIT)) { if (!(regs->tstate & TSTATE_PRIV)) { -- 1.8.3.1