On Thu, Aug 05, 2021 at 06:36:25PM +0100, Catalin Marinas wrote: > On Thu, Aug 05, 2021 at 08:50:30AM +0100, Lee Jones wrote: > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > > index b4bb67f17a2ca..cf89ce91d7145 100644 > > --- a/arch/arm64/kernel/process.c > > +++ b/arch/arm64/kernel/process.c > > @@ -212,6 +212,7 @@ void machine_restart(char *cmd) > > printk("Reboot failed -- System halted\n"); > > while (1); > > } > > +EXPORT_SYMBOL(machine_restart); > > Should we make this EXPORT_SYMBOL_GPL? I suppose it's not for general > use by out of tree drivers and it matches the other pm_power_off symbol > we export in this file. Yes please.