Re: [PATCH 1/5] uapi: remove the unused HAVE_ARCH_STRUCT_FLOCK64 define

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 1/5] uapi: remove the unused HAVE_ARCH_STRUCT_FLOCK64 define
From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Mon, 12 Apr 2021 11:55:41 +0200
Cc: Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, "the arch/x86 maintainers" <x86@xxxxxxxxxx>, Linux ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, "open list:BROADCOM NVRAM DRIVER" <linux-mips@xxxxxxxxxxxxxxx>, Parisc List <linux-parisc@xxxxxxxxxxxxxxx>, linuxppc-dev <linuxppc-dev@xxxxxxxxxxxxxxxx>, linux-s390 <linux-s390@xxxxxxxxxxxxxxx>, sparclinux <sparclinux@xxxxxxxxxxxxxxx>, linux-arch <linux-arch@xxxxxxxxxxxxxxx>
In-reply-to: <20210412085545.2595431-2-hch@lst.de>
References: <20210412085545.2595431-1-hch@lst.de> <20210412085545.2595431-2-hch@lst.de>

On Mon, Apr 12, 2021 at 10:55 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

The patch looks good, but I'd like to see a description for each one.
How about:

| The check was added when Stephen Rothwell created the file, but
| no architecture ever defined it.

        Arnd

Follow-Ups:
- Re: [PATCH 1/5] uapi: remove the unused HAVE_ARCH_STRUCT_FLOCK64 define
  - From: Stephen Rothwell

References:
- consolidate the flock uapi definitions
  - From: Christoph Hellwig
- [PATCH 1/5] uapi: remove the unused HAVE_ARCH_STRUCT_FLOCK64 define
  - From: Christoph Hellwig

Prev by Date: RE: [PATCH 5/5] compat: consolidate the compat_flock{,64} definition
Next by Date: Re: consolidate the flock uapi definitions
Previous by thread: [PATCH 1/5] uapi: remove the unused HAVE_ARCH_STRUCT_FLOCK64 define
Next by thread: Re: [PATCH 1/5] uapi: remove the unused HAVE_ARCH_STRUCT_FLOCK64 define
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [DCCP] [Linux ARM Development] [Linux] [Photo] [Yosemite Help] [Linux ARM Kernel] [Linux SCSI] [Linux x86_64] [Linux Hams]