Hello, while working on changing the prototype of struct vio_driver::remove to return void I noticed a few exit paths in such callbacks that return an error code. This is a bad thing because the return value is ignored (which is the motivation to make it void) and the corresponding device then ends in some limbo state. Luckily for the three offenders here these cases cannot happen and are simplified accordingly. This then makes the patch that changes the remove callback's prototype simpler because it only changes prototypes and drops "return 0"s. Best regards and thanks for considering, Uwe Kleine-König Uwe Kleine-König (3): tty: hvcs: Drop unnecessary if block tty: vcc: Drop unnecessary if block tty: vcc: Drop impossible to hit WARN_ON drivers/tty/hvc/hvcs.c | 3 --- drivers/tty/vcc.c | 10 ++-------- 2 files changed, 2 insertions(+), 11 deletions(-) -- 2.29.2
