On Wed, Oct 7, 2020 at 9:44 AM Christoph Hellwig <hch@xxxxxx> wrote: > > Rewrite fbiogetputcmap to call the low-level sbusfb_ioctl_{put,get}cmap > helpers directly and thus avoid usage of the deprecated > compat_alloc_user_space API. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> This is another one that I had already addressed in a somewhat inferior way. I attempted the same kind of cleanup that you did in patch 2/3 but failed to convince myself that I had managed to avoid regressions, so my patch just copy-pasted the native implementation into the compat handler with minor changes. Provided that your preparation patch is correct, this version is clearly better than mine, but again I don't know the state of that patch after Sam had said he applied it already. Arnd