On Sat, Apr 04, 2020 at 08:50:56PM +0300, Anatoly Pugachev wrote: > On Thu, Apr 2, 2020 at 8:20 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > The commit a3cb39d258ef > > ("serial: core: Allow detach and attach serial device for console") > > changed a bit logic behind lock initialization since for most of the console > > driver it's supposed to have lock already initialized even if console is not > > enabled. However, it's not the case for Sparc HV console. > > > > Initialize lock explicitly in the ->probe(). > > > > Note, there is still an open question should or shouldn't not this driver > > register console properly. > > > > Fixes: a3cb39d258ef ("serial: core: Allow detach and attach serial device for console") > > Reported-by: Anatoly Pugachev <matorola@xxxxxxxxx> > > Cc: David Miller <davem@xxxxxxxxxxxxx> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > --- > > drivers/tty/serial/sunhv.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > fixes issue for me, sorry for the late testing Thank you! Can you formally provide a Tested-by tag? -- With Best Regards, Andy Shevchenko