On 4/1/20 11:38 AM, Mike Kravetz wrote: > With all hugetlb page processing done in a single file clean up code. > - Make code match desired semantics > - Update documentation with semantics > - Make all warnings and errors messages start with 'HugeTLB:'. > - Consistently name command line parsing routines. > - Check for hugepages_supported() before processing parameters. > - Add comments to code > - Describe some of the subtle interactions > - Describe semantics of command line arguments > > Signed-off-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx> > --- Hi Mike, One nit, please see below: > .../admin-guide/kernel-parameters.txt | 35 ++++--- > Documentation/admin-guide/mm/hugetlbpage.rst | 44 +++++++++ > mm/hugetlb.c | 96 +++++++++++++++---- > 3 files changed, 142 insertions(+), 33 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 1bd5454b5e5f..de653cfe1726 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -832,12 +832,15 @@ > See also Documentation/networking/decnet.txt. > > default_hugepagesz= > - [same as hugepagesz=] The size of the default > - HugeTLB page size. This is the size represented by > - the legacy /proc/ hugepages APIs, used for SHM, and > - default size when mounting hugetlbfs filesystems. > - Defaults to the default architecture's huge page size > - if not specified. > + [HW] The size of the default HugeTLB page size. This Drop one "size" above? > + is the size represented by the legacy /proc/ hugepages > + APIs. In addition, this is the default hugetlb size > + used for shmget(), mmap() and mounting hugetlbfs > + filesystems. If not specified, defaults to the > + architecture's default huge page size. Huge page > + sizes are architecture dependent. See also > + Documentation/admin-guide/mm/hugetlbpage.rst. > + Format: size[KMG] -- ~Randy
