On Mon, Nov 11, 2019 at 7:28 PM Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > I do not like ifdefs here, do you think we could write: > > client->buffer[client->tail] = (struct input_event) { > .input_event_sec = event->input_event_sec, > .input_event_usec = event->input_event_usec, > .type = EV_SYN, > .code = SYN_DROPPED, > }; > > to ensure all padded fields are initialized? This is not hot path as we > do not expect queue to overfill too often. Good idea, changed both instances now. Thanks for taking a look! Arnd