On Sun, Aug 18, 2019 at 12:39:43PM -0700, David Miller wrote: > From: Christoph Hellwig <hch@xxxxxxxxxxxxx> > Date: Sun, 18 Aug 2019 00:01:37 -0700 > > > I think for now we'll simply have to disable HAVE_FAST_GUP for sparc, > > until someone who really knows low-level sparc page table handling > > finds some time to audit the generic fast gup code and arch hooks. > > It's a regression, we don't disable features in those circumstances > usually right? Well, it isn't exactly a feature we lost, but an optimization that makes operations go faster vs not allowing them. Them other option would be to revert the whole stack of patches, which is the groundwork for fixing the get_user_pages vs truncate and co races, so I'm not very eager to do that for sparc64. But in the end Linus will have to decice.