Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Enrico Weigelt, metux IT consult" <lkml@xxxxxxxxx>
Subject: Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Date: Mon, 29 Apr 2019 16:19:30 +0300
Cc: "Enrico Weigelt, metux IT consult" <info@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, andrew@xxxxxxxx, macro@xxxxxxxxxxxxxx, vz@xxxxxxxxx, slemieux.tyco@xxxxxxxxx, khilman@xxxxxxxxxxxx, liviu.dudau@xxxxxxx, sudeep.holla@xxxxxxx, lorenzo.pieralisi@xxxxxxx, davem@xxxxxxxxxxxxx, jacmet@xxxxxxxxxx, linux@xxxxxxxxxxxxxxx, matthias.bgg@xxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx
In-reply-to: <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-38-git-send-email-info@metux.net> <20190428152103.GP9224@smile.fi.intel.com> <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net>
User-agent: Mutt/1.10.1 (2018-07-13)

On Mon, Apr 29, 2019 at 08:48:53AM +0200, Enrico Weigelt, metux IT consult wrote:
> On 28.04.19 17:21, Andy Shevchenko wrote:

> >> +#define SERIAL_RT2880_IOSIZE	0x100
> > 
> > And why this is in the header file and not in corresponding C one?
> 
> hmm, no particular reason, maybe just an old habit to put definitions
> into .h files ;-)
> 
> I can move it to 8250_of.c if you like me to.

Please, do.

-- 
With Best Regards,
Andy Shevchenko

References:
- serial drivers polishing
  - From: Enrico Weigelt, metux IT consult
- [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation
  - From: Enrico Weigelt, metux IT consult
- Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation
  - From: Andy Shevchenko
- Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation
  - From: Enrico Weigelt, metux IT consult

Prev by Date: Re: [PATCH 01/41] drivers: tty: serial: dz: use dev_err() instead of printk()
Next by Date: Re: [PATCH 40/41] drivers: tty: serial: helper for setting mmio range
Previous by thread: Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation
Next by thread: [PATCH 40/41] drivers: tty: serial: helper for setting mmio range
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [DCCP] [Linux ARM Development] [Linux] [Photo] [Yosemite Help] [Linux ARM Kernel] [Linux SCSI] [Linux x86_64] [Linux Hams]