On Tue, Mar 26, 2019 at 10:20:41PM +0100, Thomas Gleixner wrote: > On Thu, 28 Feb 2019, Ricardo Neri wrote: > > > > > > > > -#if defined(CONFIG_HARDLOCKUP_DETECTOR_PERF) > > > > +#if defined(CONFIG_HARDLOCKUP_DETECTOR_PERF) || \ > > > > + defined(CONFIG_X86_HARDLOCKUP_DETECTOR_HPET) > > > > > > Why not instead make CONFIG_X86_HARDLOCKUP_DETECTOR_HPET select > > > CONFIG_HARDLOCKUP_DETECTOR_PERF? Keep the arch-specific details > > > in the arch-specific files and all that. > > > > Thanks for your feedback, Paul! The HPET implementation does not use > > perf. Thus, in my opinion is not correct for the HPET HLD to select > > the perf implementation. Patch 8 of this series splits the perf-specific > > code and the generic hardlockup detector code. Does this make sense? > > That's what intermediate config symbols are for. > > config HARDLOCKUP_DETECTOR_CORE > bool > > And make both PERF and HPET select it. I'll implement it in this manner. Thanks and BR, Ricardo
