On Sun, Dec 16, 2018 at 10:57:54AM +0100, Christoph Hellwig wrote: > Just decrementing the sz value will lead to an incorrect return value. > Instead of just introducing a local variable switch to the standard > for_each_sg helper and standard naming of the arguments. > > Fixes: ce65d36f3e ("sparc: remove the sparc32_dma_ops indirection") > Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx> > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> I did not look too much into the code that uses this. Your changes looks fine but I miss part of the picture so not really a review - sorry. Sam