Hi Christoph. On Sat, Dec 08, 2018 at 05:52:06PM +0100, Christoph Hellwig wrote: > On Sat, Dec 08, 2018 at 02:14:51PM +0100, Sam Ravnborg wrote: > > Hi Christoph. > > > > Nice simplification. > > > > Your patch deletes the following nice comment: > > > -/* > > > - * On LEON PCI Memory space is mapped 1:1 with physical address space. > > > - * > > > - * I/O space is located at low 64Kbytes in PCI I/O space. The I/O addresses > > > - * are converted into CPU addresses to virtual addresses that are mapped with > > > - * MMU to the PCI Host PCI I/O space window which are translated to the low > > > - * 64Kbytes by the Host controller. > > > - */ > > Maybe this is obvious and not relevant to keep? > > I could not find any code below it that this even seemed relevant to. > If it makes sense to you or other people actually involved with sparc > I can restore it. Correct, tyhe comment is general and not tied to any specific code. This is a general LEON specific comment, so lets move it to a LEON specific file. I suggest arch/sparc/include/asm/leon.h Seems easiest to do as part of your patchset rather than me submitting a new patch. Sam
