Re: [PATCH v3] sparc: set a default 32-bit dma mask for OF devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/01/2018 06:49 AM, Christoph Hellwig wrote:
This keeps the historic default behavior for devices without a DMA mask,
but removes the warning about a lacking DMA mask for doing DMA without
a mask.

Reported-by: Meelis Roos <mroos@xxxxxxxx>
Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

---

Had to redo this because the platform_device patch that the previous
version dependend on had to be dropped.

  arch/sparc/kernel/of_device_32.c | 4 ++++
  arch/sparc/kernel/of_device_64.c | 3 +++
  2 files changed, 7 insertions(+)

diff --git a/arch/sparc/kernel/of_device_32.c b/arch/sparc/kernel/of_device_32.c
index 3641a294ed54..e4abe9b8f97a 100644
--- a/arch/sparc/kernel/of_device_32.c
+++ b/arch/sparc/kernel/of_device_32.c
@@ -9,6 +9,7 @@
  #include <linux/irq.h>
  #include <linux/of_device.h>
  #include <linux/of_platform.h>
+#include <linux/dma-mapping.h>
  #include <asm/leon.h>
  #include <asm/leon_amba.h>
@@ -381,6 +382,9 @@ static struct platform_device * __init scan_one_device(struct device_node *dp,
  	else
  		dev_set_name(&op->dev, "%08x", dp->phandle);
+ op->dev.coherent_dma_mask = DMA_BIT_MASK(32);
+	op->dev.dma_mask = &op->dev.coherent_dma_mask;
+
  	if (of_device_register(op)) {
  		printk("%s: Could not register of device.\n",
  		       dp->full_name);
diff --git a/arch/sparc/kernel/of_device_64.c b/arch/sparc/kernel/of_device_64.c
index 44e4d4435bed..6df6086968c6 100644
--- a/arch/sparc/kernel/of_device_64.c
+++ b/arch/sparc/kernel/of_device_64.c
@@ -2,6 +2,7 @@
  #include <linux/string.h>
  #include <linux/kernel.h>
  #include <linux/of.h>
+#include <linux/dma-mapping.h>
  #include <linux/init.h>
  #include <linux/export.h>
  #include <linux/mod_devicetable.h>
@@ -675,6 +676,8 @@ static struct platform_device * __init scan_one_device(struct device_node *dp,
  		dev_set_name(&op->dev, "root");
  	else
  		dev_set_name(&op->dev, "%08x", dp->phandle);
+	op->dev.coherent_dma_mask = DMA_BIT_MASK(32);
+	op->dev.dma_mask = &op->dev.coherent_dma_mask;
if (of_device_register(op)) {
  		printk("%s: Could not register of device.\n",





[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux