Re: [PATCH net-next] sun: Add SPDX license tags to Sun network drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shannon,

On Wed, Feb 7, 2018 at 6:34 AM, Shannon Nelson
<shannon.nelson@xxxxxxxxxx> wrote:
> Add the appropriate SPDX license tags to the Sun network drivers
> as outlined in Documentation/process/license-rules.rst.
>
> Signed-off-by: Shannon Nelson <shannon.nelson@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/sun/Kconfig          | 1 +
>  drivers/net/ethernet/sun/cassini.c        | 1 +
>  drivers/net/ethernet/sun/cassini.h        | 1 +
>  drivers/net/ethernet/sun/ldmvsw.c         | 1 +
>  drivers/net/ethernet/sun/niu.c            | 1 +
>  drivers/net/ethernet/sun/sunbmac.c        | 1 +
>  drivers/net/ethernet/sun/sungem.c         | 1 +
>  drivers/net/ethernet/sun/sunhme.c         | 1 +
>  drivers/net/ethernet/sun/sunqe.c          | 1 +
>  drivers/net/ethernet/sun/sunvnet.c        | 1 +
>  drivers/net/ethernet/sun/sunvnet_common.c | 1 +
>  11 files changed, 11 insertions(+)
>
> diff --git a/drivers/net/ethernet/sun/Kconfig b/drivers/net/ethernet/sun/Kconfig
> index b2caf51..7b982e0 100644
> --- a/drivers/net/ethernet/sun/Kconfig
> +++ b/drivers/net/ethernet/sun/Kconfig
> @@ -1,3 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0
>  #
>  # Sun network device configuration
>  #

I'm not sure that Kconfig files count as source, right?

> diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c
> index 113bd57..9020b08 100644
> --- a/drivers/net/ethernet/sun/cassini.c
> +++ b/drivers/net/ethernet/sun/cassini.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
>  /* cassini.c: Sun Microsystems Cassini(+) ethernet driver.
>   *
>   * Copyright (C) 2004 Sun Microsystems Inc.

I understand that this is the specified way to do this, but it's
exceptionally ugly.

Also, shouldn't the SPDX line _replace_ the usual "this program is
free software" license paragraphs? My understanding is that the SPDX
line is functionally equivalent to having the terms spelled out.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux