On Thu, Nov 2, 2017 at 6:41 AM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > Hi Luc. Hi, >> +CHECKFLAGS += -mbig-endian >> + > > You have added a new assignment to CHECKFLAGS because this > options is the same for sparc32 and sparc64, which is fine. > > But could you then in the same patch > also move the assingmnet to -D__sparc__ this place, as this is also > a common option for sparc32 and sparc64. > As it is after your patch we have common options duplicated (__sparc__) > and in their own assignment (-mbig-endian). > This is inconsistent and may confuse the next reader. Yes, I agree but it seems a bit strange to me to do that in the same patch. I suppose it doesn't matter much for such small patch, anyway. -- Luc -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
