Thank you for the prompt feedback. > Don't use uint_8_t etc. in the kernel, use u8 et al. instead. > > Do not use the __packed attribute unless absolutely necessary > which seems entirely not the case for sunoem_cli_msg. Not a problem > Please remove the ILOM_PROFILING, you can achieve the same effect > with tracepoints and perf. Fair enough > Looking at the driver from a high level, it just seems to export > a seemingly arbitrary set of ILOM properties. Why not provide > a real hierarchy of all the /SYS, /HOST, etc. stuff via /sysfs? The filtering has been added to avoid leaking confidential details such as private keys and passwords. > The string parsing and matching in there is exactly the kind of > code I'm talking about which doesn't belong in the kernel. > The kernel should export a family of values for whatever (bus, > firmware settings, etc.) transparently to the user and let them > do whatever they want with whichever values they find interesting. > It is not the kernel's business to filter, not interpret, the > objects. Yet that is what these drivers are doing. Okay I got that but in this instance the parsing is necessary to allow filtering, which is in turn necessary for security. -eric -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
