From: Jag Raman <jag.raman@xxxxxxxxxx> Date: Tue, 13 Jun 2017 13:23:56 -0400 > Starting from [PATCH v1 11/12] in this series, md_node_info is > cached in "struct vio_dev", and is later used to identify VIO > devices in the MDESC. As a result, the name string in md_node_info > would be used outside of mdesc_grab()/mdesc_release(). In such > cases, caching a pointer to the property in MDESC may become a > problem. I strongly discourage this kind of string storage. Use dynamically allocated memory if you have to, otherwise you are: 1) Imposing arbitrary limits on string size. 2) Always consuming the "max" string length for every VIO device object. We have a kstrdup_const() so please use something like that. Thank you. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
