Re: [v2 4/8] sparc64: optimize loads in clock_sched()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dave,

Thank you for your comments:

When I use __cacheline_aligned instead of __aligned(64) I am getting the following error:

error: section of 'tick_operations' conflicts with previous declaration

The __section__ difference causes the issue:

__cacheline_aligned= __attribute__((__aligned__((1 << 6)), __section__(".data..cacheline_aligned")))

vs

__aligned(64) = __attribute__((aligned(64)))

Pasha

On 2017-06-12 15:06, David Miller wrote:
From: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
Date: Mon, 12 Jun 2017 12:48:23 -0400

@@ -164,7 +164,7 @@ static unsigned long tick_add_tick(unsigned long adj)
  	return new_tick;
  }
-static struct sparc64_tick_ops tick_operations __read_mostly = {
+static struct sparc64_tick_ops tick_operations __aligned(64) __read_mostly = {

Please use __cacheline_aligned instead of "__aligned(64)"
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux