Re: [v1 6/6] sparc64: initialize time early

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dave,

Thank you for your review. Sure, I can remove these restrictions, and I believe it will just work, but I do not have means to test it on that hardware.

Pasha

On 2017-06-04 22:23, David Miller wrote:
From: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
Date: Fri,  2 Jun 2017 14:40:54 -0400

@@ -792,6 +791,12 @@ static void init_tick_ops(struct sparc64_tick_ops *ops)
  	tick_operations = *ops;
  }
+void __init time_init_early(void)
+{
+	if (tlb_type != spitfire)
+		init_tick_ops(&stick_operations);
+}
+
  void __init time_init(void)
  {
  	unsigned long freq;
@@ -801,8 +806,6 @@ void __init time_init(void)
  			init_tick_ops(&hbtick_operations);
  		else
  			init_tick_ops(&tick_operations);
-	} else {
-		init_tick_ops(&stick_operations);
  	}
freq = tick_operations.frequency;

Please make this early init work properly on spitfire and hummingbird.

There is no reason to special case things like this.

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux