Re: [PATCH v3 1/5] sparc64: expand LDC interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Jag Raman <jag.raman@xxxxxxxxxx>
Date: Thu, 25 May 2017 10:25:54 -0400

> +void ldc_print(struct ldc_channel *lp)
> +{
> +	pr_info("%s: id=0x%lx flags=0x%x state=%s cstate=0x%lx hsstate=0x%x\n"
> +		"\trx_h=0x%lx rx_t=0x%lx rx_n=%ld\n"
> +		"\ttx_h=0x%lx tx_t=0x%lx tx_n=%ld\n"
> +		"\trcv_nxt=%u snd_nxt=%u\n",
> +	__func__, lp->id, lp->flags, state_to_str(lp->state),

These arguments are indented improperly, they need to line up with
the first column after the openning parenthesis of the pr_info() call.

Also, __func__ makes no sense here.  It will always be "ldc_print".
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux