From: Daniel Borkmann <daniel@xxxxxxxxxxxxx> Date: Wed, 19 Apr 2017 11:35:39 +0200 > On 04/18/2017 08:58 PM, David Miller wrote: >> + if (!prog || !prog->len) >> + return orig_prog; > > This condition can be removed, see also 93a73d442d37 > ("bpf, x86/arm64: remove useless checks on prog"), since > there's no way we could land here under such circumstance. Ok. >> + bpf_flush_icache(ctx.image, ctx.image + image_size); > > Since remaining parts were filled through jit_fill_hole(), > it would be better / more correct to flush the whole buffer, > see also the recent ppc64 commit 10528b9c45cf ("powerpc/bpf: > Flush the entire JIT buffer") that fixed it for their jit. Ok, I've made that change too, thanks! -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html