Re: tlb_batch_add_one()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Nitin Gupta <nitin.m.gupta@xxxxxxxxxx>
Date: Thu, 30 Mar 2017 17:42:51 -0700

> diff --git a/arch/sparc/mm/tsb.c b/arch/sparc/mm/tsb.c
> index 0a04811..bedf08b 100644
> --- a/arch/sparc/mm/tsb.c
> +++ b/arch/sparc/mm/tsb.c
> @@ -122,7 +122,7 @@ void flush_tsb_user(struct tlb_batch *tb)
> 
>  	spin_lock_irqsave(&mm->context.lock, flags);
> 
> -	if (tb->hugepage_shift < HPAGE_SHIFT) {
> +	if (tb->hugepage_shift < REAL_HPAGE_SHIFT) {
>  		base = (unsigned long) mm->context.tsb_block[MM_TSB_BASE].tsb;
>  		nentries = mm->context.tsb_block[MM_TSB_BASE].tsb_nentries;
>  		if (tlb_type == cheetah_plus || tlb_type == hypervisor)
> @@ -155,7 +155,7 @@ void flush_tsb_user_page(struct mm_struct *mm,
> unsigned long vaddr,
> 
>  	spin_lock_irqsave(&mm->context.lock, flags);
> 
> -	if (hugepage_shift < HPAGE_SHIFT) {
> +	if (hugepage_shift < REAL_HPAGE_SHIFT) {
>  		base = (unsigned long) mm->context.tsb_block[MM_TSB_BASE].tsb;
>  		nentries = mm->context.tsb_block[MM_TSB_BASE].tsb_nentries;
>  		if (tlb_type == cheetah_plus || tlb_type == hypervisor)
> -- 

I think if we do it like this, it will only flush one half of the huge
page.

We really need to pass HPAGE_SHIFT down into here, so that the TSB
flush gets both REAL_HPAGE_SIZE entries.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux