Re: tlb_batch_add_one()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: David Miller <davem@xxxxxxxxxxxxx>
Date: Tue, 28 Mar 2017 17:52:26 -0700 (PDT)

> 
> There seems to be some disagreement about how the hugepage state is
> passed into tlb_batch_add().  It's declared as an integer shift, but
> there are call sites that pass it in the old way, as a boolean.
> 
> For example, all of the call sites in tlb_batch_pmd_scan(), which
> likely should be passing PAGE_SHIFT.  Passing true or false in these
> spots can't be right.

And this appears to be causing regressions, gcc bootstraps fail with
all kinds of memory corruption, including in the libc malloc arena.

I did a full git bisect and it showed the multipage size support
commit as the culprit.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux