On 03/23/2017 07:47 PM, Pasha Tatashin wrote:
How long does it take if we just don't zero this memory at all? We seem
to be initialising most of struct page in __init_single_page(), so it
seems like a lot of additional complexity to conditionally zero the rest
of struct page.
Alternatively, just zero out the entire vmemmap area when it is setup
in the kernel page tables.
Hi Dave,
I can do this, either way is fine with me. It would be a little slower
compared to the current approach where we benefit from having memset()
to work as prefetch. But that would become negligible, once in the
future we will increase the granularity of multi-threading, currently it
is only one thread per-mnode to multithread vmemamp. Your call.
Thank you,
Pasha
Hi Dave and Matthew,
I've been thinking about it some more, and figured that the current
approach is better:
1. Most importantly: Part of the vmemmap is initialized early during
boot to support Linux to get to the multi-CPU environment. This means
that we would need to figure out what part of vmemmap will need to be
zeroed before hand in single thread, than zero the rest in multi-thread.
This will be very awkward architecturally and error prone.
2. As I already showed, the current approach is significantly faster.
So, perhaps it should be the default behavior even for non-deferred
"struct page" initialization: unconditionally do not zero vmemmap in
memblock allocator, and always zero in __init_single_page(). But, I am
afraid it could cause boot time regressions on some platforms where
memset() is not optimized, so I would not do it in this patchset. But,
hopefully, gradually more platforms will support deferred struct page
initialization, and this would become the default behavior.
3. By zeroing "struct page" in __init_single_page(), we set every byte
of "struct page" in one place instead of scattering it across different
places. So, it could help in the future when we will multi-thread
addition of hotplugged memory.
Thank you,
Pasha
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
