From: "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx> Date: Mon, 16 Jan 2017 13:12:14 -0500 > + return compute_effective_address(regs, insn, (insn >> 25) & > + 0x1f); Please do not split up an expression as an argument over multiple lines. Also, when a call spans multiple lines, the second and subsequent lines must start precisely at the first column after the openning parenthesis of the first line. > + unsigned long page_cnt = DIV_ROUND_UP(ent->err_size, > + PAGE_SIZE); > + > + > + /* Break the unfortunate news. */ No need for two empty line there, one is enough. Otherwise this looks good. Please fix this up and resubmit the entire series. Thanks. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
