Re: [PATCH] sparc: Clean up pci mmap function.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx>
Date: Wed, 21 Dec 2016 13:57:04 -0500

> Simplify logic for call to __pci_mmap_make_offset which only returns
> -EINVAL or zero and remove unnecessary if statement & variable from
> pci_mmap_page_range.
> 
> Signed-off-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>

This is not a legitimate simplification.  Maybe it only returns
-EINVAL as an error code now, but the whole point of returning an
explicit error code is so that in the future it can transparently be
changed to return different ones and the callers will not need
any changes.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux