Re: [PATCH v3] dbri: Fix compiler warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Tushar Dave <tushar.n.dave@xxxxxxxxxx>
Date: Thu, 24 Nov 2016 12:35:16 -0800

> dbri uses 'u32' for dma handle while invoking kernel DMA APIs,
> instead of using dma_addr_t. This hasn't caused any 'incompatible
> pointer type' warning on SPARC because until now dma_addr_t is of
> type u32. However, recent changes in SPARC ATU (iommu) enabled 64bit
> DMA and therefore dma_addr_t became of type u64. This makes
> 'incompatible pointer type' warnings inevitable.
> 
> e.g.
> sound/sparc/dbri.c: In function ʽsnd_dbri_createʼ:
> sound/sparc/dbri.c:2538: warning: passing argument 3 of ʽdma_zalloc_coherentʼ from incompatible pointer type
> ./include/linux/dma-mapping.h:608: note: expected ʽdma_addr_t *ʼ but argument is of type ʽu32 *ʼ
> 
> For the record, dbri(sbus) driver never executes on sun4v. Therefore
> even though 64bit DMA is enabled on SPARC, dbri continues to use
> legacy iommu that guarantees DMA address is always in 32bit range.
> 
> This patch resolves above compiler warning.
> 
> Signed-off-by: Tushar Dave <tushar.n.dave@xxxxxxxxxx>
> Reviewed-by: thomas tai <thomas.tai@xxxxxxxxxx>

Applied, thanks.
?τθΊ{.nΗ+?·???­?+%?Λ?±ιέΆ??w?Ί{.nΗ+?·¬??ά?)ξΗψ§Ά?ʽά¨}©?²Ζ zΪ&j:+v?¨ώψ―ω?w?ώ?ΰ2?ή?¨θ­Ϊ&ʼ)ίʽ«aΆΪ??ϋΰzΏδzΉή?ϊ+?ω???έʼj??wθώf




[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux