On Fri, Nov 25, 2016 at 07:32:28AM -0500, Sowmini Varadhan wrote:
> On (11/25/16 14:12), Dan Carpenter wrote:
> > There are several error paths where we should enable IRQs but we don't.
> >
> > Fixes: bb620c3d3925 ("sparc: Make sparc64 use scalable lib/iommu-common.c functions")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> I dont have any problem with the fix, but the commit id flagged in
> "Fixes" is inaccurate- this problem pre-existed before bb620c3d3925.
>
> I think 6a32fd4d is the commit that this Fixes.
I'm pretty sure the Fixes tag is correct. Originally it did:
+iommu_map_fail:
+ /* Interrupts are disabled. */
+ spin_lock(&iommu->lock);
+ pci_arena_free(&iommu->arena, entry, npages);
+ spin_unlock_irqrestore(&iommu->lock, flags);
+
So it enabled the Interrupts. The other patch removed the _irqrestore().
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
