Re: [PATCH 2/6] sparc64: Add ATU (new IOMMU) support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/24/2016 10:46 AM, David Miller wrote:
From: Tushar Dave <tushar.n.dave@xxxxxxxxxx>
Date: Mon, 10 Oct 2016 11:12:03 -0700

+	/* calculate size of IOTSB */
+	table_size = (atu->size / IO_PAGE_SIZE) * 8;
+	table = kzalloc(table_size, GFP_KERNEL);
+	if (!table) {
+		err = -ENOMEM;
+		goto table_failed;
+	}
+	table = (void *)IO_PAGE_ALIGN((u64)table);

If you use the page allocator directly you can avoid all of these
funny alignment calculations.
Okay. I will look into this.

@@ -931,8 +1046,10 @@ static int pci_sun4v_probe(struct platform_device *op)
 	struct pci_pbm_info *pbm;
 	struct device_node *dp;
 	struct iommu *iommu;
+	struct atu *atu;
 	u32 devhandle;
 	int i, err = -ENODEV;
+	static bool hv_atu = 1;

Please use true/false with boolean variables.
Sure.

+			hv_atu = 0;

Likewise.

Thanks.
-Tushar

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux