Re: [PATCH V2 1/2] arch/sparc: SPARC-S7 piggyback support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Joe Moriarty <joe.moriarty@xxxxxxxxxx>
Date: Tue, 24 May 2016 11:16:11 -0400

> Merge: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux
> 
> The a.out header is sometimes wrong and doesn't match the binary file
> contents for different Oracle projects using Oracle Linux. This patch
> was created to make sure the set of changes in a.out header file match
> the changes in the a.out binary file.

This doesn't explain anything to me, nor show why the calculation
changes in this patch are being made at all.

> -	if (lseek(image, offset, 0) < 0)
> +	if (lseek(image, offset, SEEK_SET) < 0)
 ...
> -		if (lseek(image, 4, 0) < 0)
> +		if (lseek(image, 4, SEEK_SET) < 0)
 ...
> +	if (lseek(image, AOUT_TEXT_OFFSET + align(end - start), SEEK_SET) < 0)
>  		die("lseek");

These "0 --> SEEK_SET" changes are firstly not metioned at all in
your commit message, and are a completely seperate change from
fixing the offsets and lengths.

Same goes for the comment spelling fix.  It's entirely unrelated
to this bug fix and needs to be in a separate patch.

This is an extremely low quality patch submission, sorry.

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux