Re: [PATCH] sparc/pci: Refactor dev_archdata initialization into pci_init_dev_archdata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Sowmini Varadhan <sowmini.varadhan@xxxxxxxxxx>
Date: Mon, 11 Apr 2016 17:57:05 -0700

> The function pcibios_add_device() added by commit d0c31e020057
> ("sparc/PCI: Fix for panic while enabling SR-IOV") initializes
> the dev_archdata by doing a memcpy from the PF. This has the
> problem that it erroneously copies the OF device without
> explicitly refcounting it.
> 
> As David Miller pointed out: "Generally speaking we don't
> really support hot-plug for OF probed devices, but if we did
> all of the device tree pointers have to be refcounted properly."
> 
> To fix this error, and also avoid code duplication, this patch
> creates a new helper function, pci_init_dev_archdata(), that
> initializes the fields in dev_archdata, and can be invoked
> by callers after they have taken the needed refcounts
> 
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@xxxxxxxxxx>
> Tested-by: Babu Moger <babu.moger@xxxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux