Re: [PATCH v2 08/30] Add sparc-specific parity functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 06, 2016 at 05:07:27PM +0800, zengzhaoxiu@xxxxxxx wrote:
> +static inline unsigned int __arch_parity4(unsigned int w)
> +	return (0x6996 >> w) & 1;

> +ENTRY(__arch_parity8)
> +	sethi		%hi(0x6996), %g1
> +	or		%g1, %lo(0x6996), %g1

> +ENTRY(__arch_parity16)
> +	sethi		%hi(0x6996), %g1
> +	or		%g1, %lo(0x6996), %g1

> +ENTRY(__arch_parity32)
> +	sethi		%hi(0x6996), %g1
> +	or		%g1, %lo(0x6996), %g1

> +ENTRY(__arch_parity64)
> +	sethi		%hi(0x6996), %g1
> +	or		%g1, %lo(0x6996), %g1

Given how many times the magic constant is repeated, maybe it would make
sense to give it a name?

-- 
     2. That which causes joy or happiness.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux