Re: [PATCH 1/1] [RFC]sparc64: enable cpu hotplug feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




  	return ret;
  }


You've made this significantly harder to review and audit by moving the code
around so much.

Just add the new calls:

	smp_fill_in_sib_core_maps();
	cpu_map_rebuild();

in the existing basic block containing the smp_synchronize_one_tick() call.

Then it's obvious to reviewers what your change is actually doing.

 Sure, I'll fix this and resend.


+	set_cpu_online(cpu, false);
+
  	/* Make sure no interrupts point to this cpu.  */
  	fixup_irqs();

This looks like a bug fix, to make sure fixup_irqs() does the right
thing, right?

All the little bug fixes like this should be split out into separate
patches.

 I really did not think it was necessary, but I'll split it up as you
said.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux