On 01/29/2016 07:23 AM, Guenter Roeck wrote:
On 01/29/2016 07:12 AM, Stanislav Kholmanskikh wrote:
On 01/29/2016 12:46 AM, Wim Coekaerts wrote:
<cut>
+static const struct watchdog_info sun4v_wdt_ident = {
+ .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
+ .identity = "sun4v hypervisor watchdog",
+ .firmware_version = 0,
+};
In accordance to watchdog_ioctl() in drivers/watchdog/watchdog_dev.c
WDIOF_KEEPALIVEPING may be needed here as to enable the support of
WDIOC_KEEPALIVE ioctl.
Correct? So maybe add it then?
Yes. Not having the flag means that the ioctl is not supported,
and that keepalives have to be implemented using file i/o.
Wim, oversight or on purpose ?
good catch, oversight from moving from the implementation of the old
_ioctl() in the driver and I didn't have a test for it in my testprogram
so missed it. Added in and tested it.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
