On 1/28/16 4:24 PM, Guenter Roeck wrote:
On 01/28/2016 02:53 PM, Wim Coekaerts wrote:
On 01/28/2016 02:50 PM, Julian Calaby wrote:
Hi Wim,
Sorry to keep iterating on this, but I noticed two small things you
could improve:
yeah I was considering that although it makes the code a bit more
readable but
fine happy to tweak that. no problem.
the static is definitely no longer needed after all the cleanup that
happened.
It would be great if you can drop the static. I'll leave the other one
for you
to decide; I was 50/50 on it myself. I don't have any further comments
(assuming
you ran the patch through checkpatch).
Thanks,
Guenter
awesome I will drop the static. I did run through checkpatch. all good
there :)
I'll sleep on the value one. :)
Thanks!
Wim
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html