On 01/25/2016 01:02 PM, Guenter Roeck wrote:
On 01/25/2016 12:38 PM, Wim Coekaerts wrote:This driver adds sparc hypervisor watchdog support. Timeout is set in milliseconds since that is the granularity supported and it honors the settings of both the watchdog-resolution and watchdog-max-timeout MD properties. Default timeout is set at 60 seconds or 60000ms. The range is between 1 second and 180 seconds. The default resolution is 1000ms. Signed-off-by: Wim Coekaerts <wim.coekaerts@xxxxxxxxxx> --- Changes in v3: - Modify sun4v_mach_set_watchdog to allow for NULL and remove time_remaining - Cleanup includes - Consolidate _start and _ping into _ping since they were the same - Fix checkpatch warnings - Remove pr_info()s - Clean up return codes to be standard kernel return values - Consolidate _init and _probe into _init Don't use platform_device anymore because this is really just a driver that depends on a hv call. This now looks more like softdog. - Cleanly check for sun4v architecture and remove extra tests - Convert to ms timer support and honor resolution since most drivers use seconds I added _ms to make it clearYou can not redefine the watchdog ABI to mean milli-seconds instead of seconds.
ugh ok. Then it makes honoring resolutions a bit useless (comment on previous patch about having a fixed 1s resolution) If I round timeout back to seconds, does the rest at least look ok now? -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
