Re: Minor tweak to silo regarding GPT labeled drives

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Anatoly Pugachev <matorola@xxxxxxxxx>
Date: Thu, 21 Jan 2016 15:52:29 +0300

> On Thu, Jan 21, 2016 at 3:11 AM, Anatoly Pugachev <matorola@xxxxxxxxx> wrote:
>> Next, compiled with gpt-patch, and applied another patch from oracle linux on
>> sparc silo.src.rpm package
>> (http://yum.oracle.com/repo/linux_sparc64/latest//silo-1.4.14-4.0.18.el6.src.rpm),
>> called silo-1.4.14-timer-timeout.patch
>>
>> diff --git a/second/timer.c b/second/timer.c
>> index 7f03996..b559f93 100644
>> --- a/second/timer.c
>> +++ b/second/timer.c
>> @@ -145,7 +145,7 @@ static inline int sun4u_init_timer ()
>>             prom_getstring(node, "device_type", node_str, sizeof(node_str));
>>              if (!strcmp(node_str, "cpu")) {
>>                  foundcpu = 1;
>> -                clock_frequency = prom_getintdefault(node, "clock-frequency", 0) / 100;
>> +                clock_frequency = (unsigned int) prom_getintdefault(node, "clock-frequency", 0) / 100;
>>              }
>>          }
>>          if (notimer) {
>> @@ -155,7 +155,7 @@ static inline int sun4u_init_timer ()
>>          }
>>      }
>>      if (!foundcpu || !clock_frequency)
>> -        clock_frequency = prom_getint(prom_root_node, "clock-frequency") / 100;
>> +        clock_frequency = (unsigned int) prom_getint(prom_root_node, "clock-frequency") / 100;
>>      if (notimer && !sun4v_cpu) {
>>          sun4u_notimer = 1;
>>          __asm__ __volatile__ ("\t"
> 
> found an owner of this patch in silo.spec changelog, quote:
> 
> * Fri Aug 30 2013 Nikita Gerasimov <nikita.gerasimov@xxxxxxxxxx> 1.4.14-4.0.14
> - silo.conf timeout property does not work due to overflow. Basically
>   the CPU is so fast now that it overslows the signed 32bit value.
>   I guess at some point it'll be even faster and we'll have to promte
>   prom_getintdefault() to returning an unsigned double int.
> 
> So we need to make Nikita Gerasimov <nikita.gerasimov@xxxxxxxxxx> as
> Signed-off-by as well.

And maybe we can ask them how to get access to this amazing "unsigned
double int" type.  I'd like to start using it too.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux