Re: [PATCH] watchdog: add sun4v_wdt device support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: wim.coekaerts@xxxxxxxxxx
Date: Tue, 12 Jan 2016 15:10:32 -0800

> +static int sun4v_wdt_stop(void)
> +{
> +	int err;
> +	unsigned long time_remaining;
> +
> +	spin_lock(&wdt_lock);
> +
> +        err = sun4v_mach_set_watchdog(0, &time_remaining);

There's a lot of lines like this last one which use spaces, instead of TAB
characters.  Please fix this up during your conversion to the watchdog
subsystem.

> +	err = sun4v_wdt_start();
> +	if (err == -EBUSY) {
> +		err = sun4v_wdt_kick();
> +	}

Single line basic blocks do not get curly braces.

> +	hp = mdesc_grab();

I don't see any mdesc_put() to release the machine description.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux