> On Apr 28, 2015, at 4:49 AM, Julian Calaby <julian.calaby@xxxxxxxxx> wrote: > > One last thing: would it be worth it to put the following before the > while loop instead of having the test inside it? I dislike invariant > tests in loops. (Incremental patch attached) > > + if (tlb_type == hypervisor) { > + while ((pbus = pci_find_next_bus(pbus)) != NULL) > + pci_sun4v_bus_slot_names(pbus); > + > + return 0; > + } That make sense, I’ll update the patch with this change. Thanks, -Eric -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html