Re: [PATCH v3] sparc64: Setup sysfs to mark LDOM sockets, cores and threads correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: David Miller <davem@xxxxxxxxxxxxx>
Date: Thu, 09 Apr 2015 19:06:47 -0400 (EDT)

> From: chris.hyser@xxxxxxxxxx
> Date: Thu, 09 Apr 2015 15:14:35 -0400
> 
>> +static void set_sock_ids(struct mdesc_handle *hp)
>> +{
>> +	u64 mp;
>> +
>> +	/* If machine description exposes sockets data use it.
>> +	 * Otherwise fallback to use L3 cache
>> +	 */
>> +	mp = mdesc_node_by_name(hp, MDESC_NODE_NULL, "sockets");
>> +	if (mp == MDESC_NODE_NULL)
>> +		return set_sock_ids_by_cache(hp, mp);
>> +
>> +	return set_sock_ids_by_socket(hp, mp);
>> +}
>> +
> 
> How will this work on T3, T2, and T1 which all neither have the
> "socket" mdesc nodes nor level 3 caches?

I'm still waiting for you to resolve this Chris.

I don't think it's much effort to make this change back down
to using the level=2 cache if no level=3 cache is found.  Please
implement that and resubmit.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux