On Thu, Apr 9, 2015 at 1:54 AM, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote: > On Wed, 2015-04-08 at 23:26 -0500, Bjorn Helgaas wrote: >> I'm not planning to review this until after the merge window opens, >> but I took a quick glance, and I agree with Ben. I don't want to add >> a new IORESOURCE_ flag. I think a pci_resource_compatible() helper is >> a great idea. > > So the new resource flag was handy here still regardless of the > implementation choice because otherwise, we have to do the whole tree > walk to check for "PCI Express only path". > > *But*, this is a property of the device as a whole, not of the resource, > so we could instead have a pci_dev flag established at probe time that > indicates that the path to a given device is PCIe only. > That way, you avoid the special resource flag alltogether. in the assign path: pci_bus_alloc_resource() does not take dev pointer. should we make int pci_bus_alloc_resource(struct pci_bus *bus, struct resource *res, to int pci_bus_alloc_resource(struct pci_bus *bus, struct pci_dev *dev, struct resource *res, ? -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
