From: David Ahern <david.ahern@xxxxxxxxxx>
Date: Mon, 30 Mar 2015 10:56:29 -0600
> On 3/30/15 10:41 AM, chris hyser wrote:
>> diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c
>> index 4b911ed..dad85fe 100644
>> --- a/drivers/block/sunvdc.c
>> +++ b/drivers/block/sunvdc.c
>> @@ -308,7 +308,11 @@ static void vdc_end_one(struct vdc_port *port,
>> struct vio_dring_state *dr,
>>
>> rqe->req = NULL;
>>
>> - __blk_end_request(req, (desc->status ? -EIO : 0), desc->size);
>> + if (desc->status) {
>> + pr_err(PFX "VIO I/O Error %d\n", desc->status);
>
> printk_ratelimit()? i.e., any chance these can come out in a flood?
Agreed. There is no benefit to spamming the logs if a series of I/O
errors occur all in a bunch, especially since the log message doesn't
print out any identifying information about the specific I/O request
that failed.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
